-
Notifications
You must be signed in to change notification settings - Fork 194
add github actions #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github actions #349
Conversation
For the full gory details of getting this up, see: bollwyvl#1 |
Build with coverage: https://github.com/bollwyvl/pythreejs/runs/1866129284 Some coverage: https://codecov.io/gh/bollwyvl/pythreejs |
Nothing else planned here, probably ready for review! |
@bollwyvl RTD is already working with GH Webhooks and RTD preview rendering in ipywidgets. No GH action needed. |
Welp, the travis one (was) running the link check, so figured I'd bring it across. Can certainly take out, if it's already being run on RTD. |
AFAI remember, the lint check step done on travis also checks links in markdown files and examples notebooks (and not just the docs). |
Run with linkchecks of everything: Of note: i did try checking the individual anchors with
...but it would be a bit of a haul to get everything fully accurate, and it could well break again in the future... |
The upstream docs are unfortunately not versioned either, so some inaccuracies are bound to happen either way 😞 |
Sorry for the commit spam, thought it would be quick update to pull in the #342 changes! 🤷 Some findings:
It would probably be good to get this in to shake down whatever else has to happen for a release... |
Yes I've seen that locally as well. Removing the
I'll give it a go to ensure that end-users are not going to see any increases. If the CI time is not being spent doing obvious "duplicate" work, I don't think this repo has a high enough activity level to spend too much time optimizing things.
Yes, it would be good if the lab extension builder package could be a separate package with a minimal dependency tree, since it will be installed for all sdist installs as well. I also want to check that sdist installs work when node is not available on the system. |
.github/workflows/ci.yml
Outdated
- name: Install package and docs dependencies | ||
run: | | ||
set -eux | ||
pip install -vv -U .[docs,examples,test] requests_cache 'traitlets==4.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which bits are broken with traitlets 5? Would you mind linking to an issue, or creating a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, lotta force-pushin', hard to dig back up. It was something about one of the fancy enum traits...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made #351, got CI to show the issue.
Given there is no functional CI working, it would be lovely to get this merged so we're not having to look at a fork... likely we could iterate more effectively, and in parallel...
The 3.6 excursions all install from sdist, and have the assets: https://github.com/bollwyvl/pythreejs/runs/1916098289?check_suite_focus=true#step:7:21581 |
Hooray!
|
This adds a GitHub Actions CI, derived from a number of other ones in the community. This is a single workflow, with one tiny change to
conf.py
to avoid a long-deprecated API. I figure we can remove the travis job separately, maybe try to get RTD back up and running (might need to request the mamba feature flag).I'm working directly off my
master
branch, where you can see my Many Commits of Shame with the occasional ✔️Overview:
Possible Follow-on
extras
requirements.txt
,yarn.lock
, etc. would be needed to drive entropy